Add TypeScript definitions #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Desperately need this. Can anyone merge this with master? |
|
Hey Ninty @c19354837 ! I went ahead and added a patch-version bump commit, with changelog entry, and tried to match your existing patterns. |
|
Thanks for your work! |
|
v1.7.5 is available |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Been using these types for a while - saw issue #111 and wanted to chip in!
I was tempted to add
enums for things like the volume types, "screenMode" int, "locationMode" int, etc, but since the library does not export those, I figured a no-JS-change PR would be appropriate first.